If you want a spot-on accurate x-craft, this kit isn't the best place to start, because almost nothing tally's with a good plan of this type of craft.
The Darnell boats date back to pre-internet age,when information was much more difficult to come by, and consequently many models were built with a big dollop of artistic license.
The enduring appeal of the Darnell range, against what could be considered more accurate models was that it offered an entry point into the hobby at a competitive price point, however the models did require quite a bit of work on behalf of the builder, many items needing to be scratchbuilt to complete the model.
Most model submarine kits these days come with a high level of prefabrication, which makes life easier for the builder, but up goes the price accordingly.
However the Darnell does build into a very nice and capable model submarine which works well either as a dynamic or static diver. The untrained eye will not spot the inconsistencies with the original boats and this model, and a competent modeller can go a long way to either rectifying or disguising some of the less accurate areas if they choose to.
Regarding cylinder and ballast tank sizing, I don't have that boat so can't give you precise dimensions. The cylinder should be large enough to support it's own weight, plus all the equipment you put into it, plus the extra density of a GRP hull, which will always be heavier than water by about 20-50% depending on the lay-up.
Regarding ballast tank size, I would take a guess at somewhere about 300ml, bear in mind that there will be some variation amongst even identical boats as these are hand laid GRP mouldings.
The best way is to build your boat and cylinder, put it in the bath/test tank, ballast the boat to the desired submerged waterline, then use blocks of polystyrene foam to bring the boat the correct surfaced waterline. Add the volume of the foam blocks together and you have the required volume of your tank.
This is very much easier and more accurate than calculation. You'll usually have to make some type of cradle to support and locate the foam blocks, this should be made from something neutrally buoyant, so it doesn't skew your results. Plasticard (styrene sheet) tends to be about the same gravity as water, so that would be a good choice.